Converted client library to JAR without generating AAR#8
Merged
Conversation
Fix related problems like org.apache.httpcomponents package collision. bintray publish now controlled by property Fixed 404 test. Migrated client androidTest to test and JUnit
Ignore client/pom.xml as it's generated
Member
Author
There was a problem hiding this comment.
Changed to "NotFound" which looks correct to me. @mythz could you review?
Member
There was a problem hiding this comment.
Yeah this was a recent change to use the StatusCode as the ErrorCode instead of re-using the ErrorMessage.
Layoric
added a commit
that referenced
this pull request
Oct 11, 2015
Converted client library to JAR without generating AAR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've converted the
clientlibrary to a plain JAR, removed android dependencies and included the additional dependency oforg.apache.httpcomponents:httpmime:4.2.3.Fixed 404 tests for
clientandandroid. Needs review as I'm not sure if they were passing before or not. Now expectNotFoundfor error andnot herefor message.